Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: url source extraction for file:/// urls #1164

Merged
merged 3 commits into from
Nov 6, 2024
Merged

fix: url source extraction for file:/// urls #1164

merged 3 commits into from
Nov 6, 2024

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Nov 6, 2024

This improves the URL source type in two ways:

  • file:/// urls are treated exactly the same as remote urls. We copy the file to the cache, and extract it.
  • Extraction is now conditional on a "file_name". If a file_name is set, we will rename the archive to the file_name value and insert it as an archive in the work dir. This helps for example when packaging a NPM package as it seems to work better from an archive :)

@wolfv wolfv mentioned this pull request Nov 6, 2024
Closed
@wolfv wolfv merged commit 9d681e0 into prefix-dev:main Nov 6, 2024
18 of 19 checks passed
wolfv added a commit to wolfv/rattler-build that referenced this pull request Nov 6, 2024
@wolfv
fix: url source extraction for file:/// urls (prefix-dev#1164)
6a364bd
@BrewTestBot BrewTestBot mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wolfv